From 3916f3dbb94ecafeebbadda9bd955db6035e2989 Mon Sep 17 00:00:00 2001
From: Bart van der Braak <bartvdbraak@gmail.com>
Date: Fri, 1 Dec 2023 14:45:12 +0100
Subject: [PATCH] feat: add conditionals to tests

---
 .github/workflows/tests.yml | 21 +++++++++++----------
 1 file changed, 11 insertions(+), 10 deletions(-)

diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml
index 1da5d56..57e1427 100644
--- a/.github/workflows/tests.yml
+++ b/.github/workflows/tests.yml
@@ -21,7 +21,8 @@ jobs:
     steps:
     - uses: actions/checkout@v3
     - name: Fetch complete history
-      run: git fetch --prune --unshallow
+      run: |
+        git fetch --prune --unshallow --tags
     - name: Check for deployed tag
       id: check_tag
       run: |
@@ -43,7 +44,7 @@ jobs:
   bicep:
     name: Deploy Azure resources
     needs: bicep-pre-check
-    if: ${{ needs.bicep-pre-check.outputs.deployed_tag_exists }} == 'false' || ${{ needs.bicep-pre-check.outputs.no_changes }} == 'false'
+    if: needs.bicep-pre-check.outputs.deployed_tag_exists == 'false' || needs.bicep-pre-check.outputs.no_changes == 'false'
     environment: bicep
     runs-on: ubuntu-latest
     concurrency:
@@ -75,13 +76,13 @@ jobs:
   tests-no-access:
     name: Tests with No Access
     needs: bicep
+    if: always() && !contains(needs.*.result, 'failure') && !contains(needs.*.result, 'cancelled')
     runs-on: ubuntu-latest
     environment: test
     steps:
     - uses: actions/checkout@v4
     - uses: dtolnay/rust-toolchain@stable
-    - name: 'Az CLI login'
-      uses: azure/login@v1
+    - uses: azure/login@v1
       with:
         client-id: ${{ secrets.AZURE_CLIENT_ID_NO_ACCESS }}
         tenant-id: ${{ secrets.AZURE_TENANT_ID }}
@@ -91,13 +92,13 @@ jobs:
   tests-get:
     name: Tests with Get
     needs: bicep
+    if: always() && !contains(needs.*.result, 'failure') && !contains(needs.*.result, 'cancelled')
     runs-on: ubuntu-latest
     environment: test
     steps:
     - uses: actions/checkout@v4
     - uses: dtolnay/rust-toolchain@stable
-    - name: 'Az CLI login'
-      uses: azure/login@v1
+    - uses: azure/login@v1
       with:
         client-id: ${{ secrets.AZURE_CLIENT_ID_GET }}
         tenant-id: ${{ secrets.AZURE_TENANT_ID }}
@@ -107,13 +108,13 @@ jobs:
   tests-list:
     name: Tests with List
     needs: bicep
+    if: always() && !contains(needs.*.result, 'failure') && !contains(needs.*.result, 'cancelled')
     runs-on: ubuntu-latest
     environment: test
     steps:
     - uses: actions/checkout@v4
     - uses: dtolnay/rust-toolchain@stable
-    - name: 'Az CLI login'
-      uses: azure/login@v1
+    - uses: azure/login@v1
       with:
         client-id: ${{ secrets.AZURE_CLIENT_ID_LIST }}
         tenant-id: ${{ secrets.AZURE_TENANT_ID }}
@@ -123,13 +124,13 @@ jobs:
   tests-get-list:
     name: Tests with Get and List
     needs: bicep
+    if: always() && !contains(needs.*.result, 'failure') && !contains(needs.*.result, 'cancelled')
     runs-on: ubuntu-latest
     environment: test
     steps:
     - uses: actions/checkout@v4
     - uses: dtolnay/rust-toolchain@stable
-    - name: 'Az CLI login'
-      uses: azure/login@v1
+    - uses: azure/login@v1
       with:
         client-id: ${{ secrets.AZURE_CLIENT_ID_GET_LIST }}
         tenant-id: ${{ secrets.AZURE_TENANT_ID }}